Skip to content

Inline pqxx type_name variables #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2025

Conversation

dylanlanigansmith
Copy link
Contributor

avoids ODR violations and makes library much easier to integrate into larger projects.

avoids ODR violations and makes library much easier to integrate into larger projects.
@ankane
Copy link
Member

ankane commented Jul 10, 2025

Hi @dylanlanigansmith, thanks for the PR! Reached out to libpqxx in the issue above to figure out the correct signature.

@ankane ankane merged commit 62f4b30 into pgvector:master Jul 13, 2025
1 check passed
ankane added a commit that referenced this pull request Jul 13, 2025
@ankane
Copy link
Member

ankane commented Jul 13, 2025

Updated the return type to std::string_view in the commit above. Thanks for reporting the issue and the PR!

@dylanlanigansmith
Copy link
Contributor Author

Thank you! Least I could do, love the library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants