Adding a recursive range query method to the KdTree class. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a recursive range query. Two methods were added: searchNodeRangeRecursive and rangeRecursive. Given a node and a range (eps), the method range recursive executes searchNodeRangeRecursive, that returns all the nodes within an eps distance.
| axisDistance = DBScan.getDistance(value.getX(), root.id.getX(), value.getY(), value.getY()); | ||
| } else if (axis==Y_AXIS) { | ||
| axisDistance = DBScan.getDistance(value.getX(), value.getX(), value.getY(), root.id.getY()); | ||
| } |
There was a problem hiding this comment.
You don't account for Z_AXIS here.
|
@antoniocavalcante I'll merge the pull request when you account for Z_AXIS. But it won't be a direct merge since you changed the package name and reformatted. |
| } | ||
|
|
||
| @SuppressWarnings("unchecked") | ||
| public Collection<Integer> rangeRecursive(T value, double eps) { |
There was a problem hiding this comment.
@antoniocavalcante You should probably rename to searchRange since the user shouldn't care how (recursive) you are searching. Also, it'd be nice to know the units of eps and if it's <= eps or < eps for the results,
|
@antoniocavalcante By the way, thanks for the pull request! |
|
@antoniocavalcante Also.. DBScan.getDistance() is undefined. You should probably include that in the KDTree; how is it different than euclidean distance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a recursive range query. Two methods were added: searchNodeRangeRecursive and rangeRecursive.
Given a node and a range (eps), the method range recursive executes searchNodeRangeRecursive, that returns all the nodes within an eps distance.