Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: php/php-src
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: dcaf62f
Choose a base ref
...
head repository: php/php-src
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: efce369
Choose a head ref
  • 9 commits
  • 24 files changed
  • 2 contributors

Commits on Jul 20, 2020

  1. Add missing arg num check for __set_state

    @nikic
    nikic committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    b466e8b View commit details
    Browse the repository at this point in the history

  2. Unify static/non-static check for magic methods 

    And promote it to be fatal.
    @nikic
    nikic committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    fbbcf82 View commit details
    Browse the repository at this point in the history

  3. Unify magic method return type checks

    @nikic
    nikic committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    312fe2b View commit details
    Browse the repository at this point in the history

  4. Fix tests I missed before

    @nikic
    nikic committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    015fc63 View commit details
    Browse the repository at this point in the history

  5. Remove old code (BP_VAR_RW warning)

    @dstogov
    dstogov committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    9f0213f View commit details
    Browse the repository at this point in the history

  6. Unify magic method visibility check 

    This was missing entirely for the internal function case.
    @nikic
    nikic committed Jul 20, 2020
    2 Configuration menu
    Copy the full SHA
    149029b View commit details
    Browse the repository at this point in the history

  7. Report magic method names as written 

    Report the name the way the user has written it, the same way we
always do.
    @nikic
    nikic committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    19de727 View commit details
    Browse the repository at this point in the history

  8. Remove unused lc_class_name variable 

    This is probably a leftover from "old style constructor" support.
    @nikic
    nikic committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    91e5452 View commit details
    Browse the repository at this point in the history

  9. Directly assign magic methods 

    Instead of going through intermediary variables.
    @nikic
    nikic committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    efce369 View commit details
    Browse the repository at this point in the history
Loading