Skip to content

Incorrect error message when passing null to join/implode's array parameter #12682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
CViniciusSDias opened this issue Nov 15, 2023 · 0 comments · Fixed by #12683
Closed

Incorrect error message when passing null to join/implode's array parameter #12682

CViniciusSDias opened this issue Nov 15, 2023 · 0 comments · Fixed by #12683
Labels
Bug Status: Needs Triage

Comments

@CViniciusSDias
Copy link
Contributor

Description

The following code:

<?php
try {
    join('', null);
} catch (TypeError $e) {
    echo $e->getMessage();
}
?>

Resulted in this output:

join(): Argument #1 ($pieces) must be of type array, string given

But I expected this output instead:

join(): Argument #2 ($array) must be of type array, null given

PHP Version

PHP 8.2.10

Operating System

No response
CViniciusSDias added a commit to CViniciusSDias/php-src that referenced this issue Nov 15, 2023
@CViniciusSDias
Fixes php#12682
72c6102
@CViniciusSDias CViniciusSDias mentioned this issue Nov 15, 2023
Merged
CViniciusSDias added a commit to CViniciusSDias/php-src that referenced this issue Nov 17, 2023
@CViniciusSDias
Fixes php#12682
c250a71
CViniciusSDias added a commit to CViniciusSDias/php-src that referenced this issue Nov 20, 2023
@CViniciusSDias
Fixes php#12682
1cf7390
CViniciusSDias added a commit to CViniciusSDias/php-src that referenced this issue Nov 22, 2023
@CViniciusSDias
Fixes php#12682
469981b
Girgias pushed a commit that referenced this issue Dec 1, 2023
@CViniciusSDias
Fixing incorrect error message when passing null to join/implode's ar…
f1af722 
…ray parameter (#12683)

Closes GH-12682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Status: Needs Triage
Projects
None yet
Milestone
No milestone
1 participant
@CViniciusSDias