Hello! I'm one of the authors of Ada URL. How was your local benchmarks? I'd like to help and understand why this PR was closed.

I wonder if curl's urlapi might be useful, since it'd be consistent with ext/curl.

I wonder if curl's urlapi might be useful, since it'd be consistent with ext/curl.

To be honest, I don't really like it. But I'd only start thinking about the API if I manage to sort the rest of the problem out, specifically the issue with the C++ 17 dependency.

Note, adding support for URL parsing from curl was rejected a year ago. https://wiki.php.net/rfc/curl-url-api I'm also not sure if making curl a required dependency is going to fly. Unless I'm misunderstanding what you're saying.

specifically the issue with the C++ 17 dependency.

Are you aiming PHP 9 or earlier ?
Also, for example, would there a performance impact if you ditch string_view (no idea, real question)

Are you aiming PHP 9 or earlier ?

Possibly earlier, but I'm not sure how we can resolve the C++ dependency issue. I mean, I don't see much sense to add Ada as an optional extension, as URL parsing is pretty much a core thing.

Also, for example, would there a performance impact if you ditch string_view (no idea, real question)

Me neither, although I'm not sure what you mean by ditching it? I don't use string_view. But @anonrig may be able to answer it. :)

Me neither, although I'm not sure what you mean by ditching it? I don't use string_view. But @anonrig may be able to answer it. :)

Yes true you do not use, but ada itself use typical useful C++17 features (e.g. std::optional).

After a discussion with the PHP Foundation members, it turned out that we cannot yet rely on C++, not to mention C++ 17 indeed in case of mandatory extensions. That's why I won't continue to work on ext/url anymore since I believe such core features like URL parsing should always be available, and shouldn't be in optional extensions. That's why I'm closing this PR for now. Anyone who feels like continuing the effort should feel free to take it over.

Isn't the ICU extension C++ out of necessity? A more conservative dialect, but still C++.

Isn't the ICU extension C++ out of necessity? A more conservative dialect, but still C++.

Ada doesn't depend on ICU

I was talking about ext/icu, WRT precedent.

@NattyNarwhal Yes, but ext/intl is an optional extension, meaning you can still build PHP without intl and without C++.