Additional tests for SplFileObject #117
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests look good to me. I would suggest you to commit them directly. See the wiki for a PR merge howto: https://wiki.php.net/vcs/gitworkflow#reviewing_and_closing_pull_requests |
|
Does this mean I have to apply for a Git-account: http://php.net/git-php.php? |
|
Sorry, I thought Rafael opened this PR, as he has commit access for tests afair. |
|
Ok, then I'll wait for his responds. Thanks. |
| 'READ_AHEAD', | ||
| 'SKIP_EMPTY', | ||
| 'READ_CSV', | ||
| ); |
There was a problem hiding this comment.
This array is not used anywhere in the test.
| print_r(PDO::getAvailableDrivers()); | ||
| ?> | ||
| --EXPECT-- | ||
| Array |
There was a problem hiding this comment.
Why this test assumes only sqlite driver is available?
|
I've merged the SPL ones but not PDO ones (see comment above about it). Please fix and resubmit PDO patch. |
|
Comment on behalf of stas at php.net: merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New tests created during PZF TestFest, mentored by Rafael Dohms