ext/libxml: Add test to attempt to trigger a specific code path #11728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdos
approved these changes
Jul 17, 2023
|
|
||
| class Handler { | ||
| public function handle($public, $system, $context) { | ||
| return dba_open('db.dba', 'n');//throw new Exception(); |
There was a problem hiding this comment.
This comment at the end should be removed probably.
|
I do think this test should be moved to ext/dom though. |
Other tests in this folder deal with this function and require the DOM extension so I'm kinda reluctant to move this to ext/dom. |
|
Ah yes that's fair, fine by me then! |
|
@iluuu1994 what generated file is it complaining about? I can't figure it out >_> |
|
It's |
…eing loaded A stream resource is expected to be returned by the handler.
|
Right... I forgot a |
|
Yeah it looks OK now, thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't remember when I did this as I've been going through some old branches, maybe this is useful?