Generate the new class synopsis markup #11809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Jul 28, 2023
Comment on lines
+3054
to
+3065
| if ($this->type === "class") { | ||
| foreach ($this->implements as $interfaceName) { | ||
| $interface = $classMap[$interfaceName->toString()] ?? null; | ||
| if ($interface === null) { | ||
| throw new Exception("Missing implemented interface " . $interfaceName->toString()); | ||
| } | ||
|
|
||
| if ($interface->isException($classMap)) { | ||
| return true; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Is this just to check that Error and Exception have an implements Throwable? that seems kinda overkill? logically every other exception must be extending one of these two classes so maybe it makes more sense to just special case those two classes and let the other loop do its job.
Either case this is also fine.
There was a problem hiding this comment.
I didn't want to rely on the fact that exceptions currently either extend Error or Exception so that's why I used the more general approach. I'm fine with special casing the logic if you want to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following php/phd#77