Opcodefy Magical __call/_callStatic #1231
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First this fixed Bug #68412 (Infinite recursion with __call can make the program crash/segfault)
Second this make call to __call/__callStatic faster (48% faster)
There are only two tests fails now:
When call() is invoked via ::, ensure current scope's call() is favoured over the specified class's __call(). [tests/classes/__call_004.phpt]
Bug #50383 (Exceptions thrown in call / callStatic do not include file and line in trace) [Zend/tests/bug50383.phpt]
I think the current behavior in __call_004.phpt is weird.. maybe we should not support it?
and regarding to the sencode fails, it seems to be a expected change.. we could fix the test instead?
thanks