Fix GH-12850: DOMNameSpaceNode parent not unset when namespace gets unlinked #12897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s unlinked The problem is that the namespace nodes are exposed as fake nodes because of their different underlying data structure, which means that the parent link isn't actually updated when it gets removed; and we don't have a simple way of tracking it. So just perform a check for the node type and check whether the namespace declaration associated with the fake node is still in existence.
|
The fix is insufficient. The only way to fix all of this mess is by fixing spec compliance, so postponing for that RFC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that the namespace nodes are exposed as fake nodes because of their different underlying data structure, which means that the parent link isn't actually updated when it gets removed; and we don't have a simple way of tracking it.
So just perform a check for the node type and check whether the namespace declaration associated with the fake node is still in existence.
Note that the namespace nodes are created when query() executes, so just before the foreach loops. Hence we are able to test that the node can be fetched but the parent is already unset upon first time the object is read.