Remove warning "use statement with non-compound name '...' has no effect" #12949
Conversation
…ect"
This message was in fact not true, as the statement indeed *has* an effect,
that is fixing the case for a potential autoloading invocation, as in:
use Alpha;
new alpha(); // will issue autoload for "Alpha" instead of "alpha"
This is very relevant for case-sensitive file systems that load classes
using their name as file name.
I very much disagree with this, if the language can do something and warn about errors, then it should. We should not aim to delegate everything to SA, frankly we should do the opposite. |
So the PHP engine should raise a warning for situations like: or ? Anyway, this is not what the PR is about, as the |
|
It's true that we generally do not emit warnings even for obvious mistakes. E.g. duplicate switch/match cases. I don't mind dropping this, but maybe send a short message to the ML. |
Depends.
I'd recommend to seek solving the local problem and addressing a better upstream target, instead of removing the diagnostic message that helped you discovering the filename portability issue first of all - by appearing misplaced or wrongworded. @thg2k |
This message was in fact not true, as the statement indeed has an effect, that is fixing the case for a potential autoloading invocation, as in:
This is very relevant for case-sensitive file systems that load classes using their name as file name.
Moreover, there is not a reason to issue a warning for no-ops, this is a task for static analyzers, not the language itself.