Skip to content

Dereferencing process-handles no longer waits on those processes #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Dereferencing process-handles no longer waits on those processes #130

wants to merge 1 commit into from

Conversation

Jille
Copy link
Contributor

@Jille Jille commented Jul 12, 2012 

When handles created by proc_open() and popen() got destroyed they called waitpid() and waited for the process to exit. Now they only wait if they are explicitly closed with proc_close() or pclose().

Implements FR #46487

I will also send this over internals to be discussed.

@lstrojny
Copy link
Contributor

lstrojny commented Jan 6, 2013

@Jille patch looks good. Can you add a test for your patch?

@lstrojny
Copy link
Contributor

Could you rebase and squash?

@Jille
Copy link
Contributor Author

Jille commented Jan 15, 2013

I've committed f2bad2c to Jille/php-src:proc_close_lingering_squashed.

@lstrojny
Copy link
Contributor

Please force push to this PR as well.

@Jille
Copy link
Contributor Author

Jille commented Jan 15, 2013

Done.

@lstrojny
Copy link
Contributor

Hm, the test is gone?

@Jille
Copy link
Contributor Author

Jille commented Jan 15, 2013

I'm sorry. Fixed.

@php-pulls
Copy link

Comment on behalf of lstrojny at php.net:

Merged into 5.5 and master. 5.5 and not 5.4 because it comes with an ABI break.

@php-pulls php-pulls closed this Jan 15, 2013
@dunglas dunglas mentioned this pull request Sep 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jille @lstrojny @php-pulls