Skip to content

Fix EINPROGRESS very rarely occurring on synchronous php_network_connect_socket() #13252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix EINPROGRESS very rarely occurring on synchronous php_network_connect_socket() #13252

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions main/network.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,11 @@ PHPAPI int php_network_connect_socket(php_socket_t sockfd,
if (getsockopt(sockfd, SOL_SOCKET, SO_ERROR, (char*)&error, &len) != 0) {
ret = -1;
}
if (error == EINPROGRESS) {
/* Is leftover from the earlier connect call, since php_socket_errno
* does not clear it. */
error = 0;
}
} else {
/* whoops: sockfd has disappeared */
ret = -1;
Expand Down