Fixes mcrypt_ecb not issuing an E_DEPRECATED level notice #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ving been deprecated for some time. Please reference bug #62374 as well.
|
This is the wrong approach. It should use ZEND_ACC_DEPRECATED as function flag so reflection etc. can refer to it properly. |
|
I don't understand wha tyou mean by "should use ZEND_ACC_DEPRECATED as function flag so reflection etc. can refer to it properly.".. I don't see this anywhere else where functions are issuing E_DEPRECATED errors, but if you can elaborate I'll be happy to fix it and resubmit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mcrypt_ecb not issuing an E_DEPRECATED level notice, despite having been deprecated for some time. Please reference bug #62374 as well.