Fix tests when stdout is unbuffered #13924
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests spawn a sub-process with
-d extension=phar.so
, which emits a warning onstdout
when the extension is compiled statically in the php binary.In glibc,
stdout
is buffered, and we also don't flush it explicitly. The process is later killed with SIGTERM, so the buffer is never flushed, and the warning is not visible.With musl,
stdout
is unbuffered (or maybe line-buffered, or the buffer is smaller), so the warning is visible, causing the tests to fail.In this PR I add
-d extension=phar.so
only ifphar
was compiled as a dynamic module, so that no warning is emitted.This is out of scope of this PR, but we should probably flush after emitting a warning. Also, I think that warnings go to
stdout
as part of thedisplay_errors
functionality, but ideally they should be written tostderr
when using the CLI SAPI.