Skip to content

Add ReflectionClassConstant::isDeprecated() #14086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2024
Merged

Add ReflectionClassConstant::isDeprecated() #14086

merged 1 commit into from
Apr 30, 2024

Conversation

TimWolla
Copy link
Member

This is in preparation for #11293 and for consistency with ReflectionConstant::isDeprecated() that was added in #13669.

@TimWolla
Add ReflectionClassConstant::isDeprecated()
9f0b64c 
This is in preparation for php#11293 and for consistency with
ReflectionConstant::isDeprecated() that was added in php#13669.
@TimWolla TimWolla requested a review from iluuu1994 April 30, 2024 14:19
@TimWolla TimWolla requested a review from kocsismate as a code owner April 30, 2024 14:19
iluuu1994
iluuu1994 approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Supporting this in userland might require some special handling when evaluating constant ASTs, so that the flag in zval.u2 is preserved. But let's deal with that when the time comes. 🙂

@TimWolla TimWolla merged commit b5ffac7 into php:master Apr 30, 2024
10 checks passed
@TimWolla TimWolla deleted the reflection-class-constant-is-deprecated branch April 30, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluuu1994 iluuu1994 iluuu1994 approved these changes

@kocsismate kocsismate Awaiting requested review from kocsismate kocsismate is a code owner

Assignees
No one assigned
Labels
Extension: reflection Extension: zend_test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimWolla @iluuu1994