Skip to content

random: Add PHPAPI to all php_random_algo definitions #14088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

TimWolla
Copy link
Member

The php_random.h header already defines them as PHPAPI and they actually are part of the public API.


see #14054 (comment)

The php_random.h header already defines them as `PHPAPI` and they actually are
part of the public API.

Co-authored-by: Arnaud Le Blanc <arnaud.lb@gmail.com>
Copy link
Member

@arnaud-lb arnaud-lb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TimWolla TimWolla merged commit d5cc7e9 into php:master Apr 30, 2024
9 of 10 checks passed
@TimWolla TimWolla deleted the random-algo-phpapi branch April 30, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants