Skip to content

Fix GH-11188: Error when building TSRM in ARM64 (for IR JIT) #14459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2024
Merged

Fix GH-11188: Error when building TSRM in ARM64 (for IR JIT) #14459

merged 1 commit into from
Jun 4, 2024

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Jun 3, 2024

This is GH-11236 for IR JIT.
TSRM change is the same.
The only real difference is the place where the tsrm_tls_offset and tsrm_tls_index are filled in for FreeBSD but the code is otherwise identical.
Asking @arnaud-lb for review as he did it for the 8.2 & 8.3 version.

@nielsdos nielsdos requested a review from arnaud-lb June 3, 2024 20:09
@petk
Copy link
Member

petk commented Jun 3, 2024

Not related to this issue probably, but there is also some bug happening on FreeBSD 32-bit when building with Clang (default) on all branches (tested with PHP-8.3 and master):

ld: error: relocation R_386_32 cannot be used against local symbol; recompile with -fPIC
>>> defined in ext/opcache/.libs/zend_accelerator_debug.o
>>> referenced by zend_accelerator_debug.c:58 (ext/opcache/zend_accelerator_debug.c:58)
>>>               ext/opcache/.libs/zend_accelerator_debug.o:(zend_accel_error_va_args)

This is something related?

@nielsdos
Copy link
Member Author

nielsdos commented Jun 3, 2024

This is something related?

Different issue than this, I can check that out sometime this week, but I'd have to setup a VM with FreeBSD 32-bit first.

@petk
Copy link
Member

petk commented Jun 3, 2024

Ok, no problem. I'll open a bug at some point on the way...

arnaud-lb
arnaud-lb approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@arnaud-lb arnaud-lb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nielsdos nielsdos merged commit 89c4e4c into php:master Jun 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaud-lb arnaud-lb arnaud-lb approved these changes

@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

@iluuu1994 iluuu1994 Awaiting requested review from iluuu1994

Assignees
No one assigned
Labels
Extension: opcache
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nielsdos @petk @arnaud-lb