Skip test if libxml does not support GBK encoding #15072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It doesn't necessarily have to be GBK, another CJK encoding would do too, but I guess musl's encoding support is limited in general. |
When libxml uses musl iconv, GBK encoding is not supported as a target encoding
|
Thank you! Yes, musl's iconv does not support most multibyte encodings as target encoding. I've updated the test to use SHIFT-JIS instead as it is supported as both source and target. Edit: FreeBSD doesn't support SHIFT-JS apparently. Will try to find one that is supported everywhere. |
Merged
|
Using |
nielsdos
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When libxml uses musl's iconv implementation, conversion to GBK is not supported. As a result this test fails like this:
Here I try to skip the test in this case.
The skipif section is quite large, unfortunately. Checking that iconv supports GBK via the iconv extension wouldn't be reliable as it may be linked against gnu iconv even on musl builds.