Skip to content

ext/(standard|spl): Deprecate passing a non-empty string as the $escape parameter #15362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2024
Merged

ext/(standard|spl): Deprecate passing a non-empty string as the $escape parameter #15362

merged 1 commit into from
Aug 12, 2024

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Aug 12, 2024

@Girgias Girgias requested a review from cmb69 August 12, 2024 13:25
@Girgias Girgias requested a review from bukka as a code owner August 12, 2024 13:25
cmb69
cmb69 approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the nit below, this looks good to me.

@Girgias Girgias merged commit c818d94 into php:master Aug 12, 2024
10 checks passed
@Girgias Girgias deleted the step2-csv-rfc branch August 12, 2024 15:10
@jrfnl jrfnl mentioned this pull request Sep 17, 2024
Merged
@cmb69 cmb69 mentioned this pull request Sep 17, 2024
Merged
@jrfnl jrfnl mentioned this pull request Sep 27, 2024
Merged
@jrfnl jrfnl mentioned this pull request Oct 6, 2024
Merged
@Girgias Girgias changed the title ext/(standard|spl): Deprecate passing a non-empty string as the $enclosure parameter ext/(standard|spl): Deprecate passing a non-empty string as the $escape parameter Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimWolla TimWolla TimWolla left review comments

@cmb69 cmb69 cmb69 approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees
No one assigned
Labels
Extension: spl Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Girgias @TimWolla @cmb69