Skip to content

[skip ci] PHP 8.4 NEWS: fix typos in parameter names #15931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2024
Merged

[skip ci] PHP 8.4 NEWS: fix typos in parameter names #15931

merged 1 commit into from
Sep 17, 2024

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Sep 17, 2024

@jrfnl
Copy link
Contributor Author

jrfnl commented Sep 17, 2024

Looks like #15569 changed the behaviour once again. Should I update the text to match the changed UPGRADING entry as per f756b96 ?

@iluuu1994 iluuu1994 requested a review from Girgias September 17, 2024 11:00
@Girgias
Copy link
Member

Girgias commented Sep 17, 2024

Looks like #15569 changed the behaviour once again. Should I update the text to match the changed UPGRADING entry as per f756b96 ?

It is an old NEWS entry, so it would rather require a new one for the next release.

@Girgias Girgias merged commit 4830535 into php:master Sep 17, 2024
2 checks passed
@jrfnl jrfnl deleted the feature/news-fix-param-name branch September 17, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Awaiting requested review from Girgias

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrfnl @Girgias