Skip to content

Travis: --enable-dba --with-gdbm --tcadb #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Travis: --enable-dba --with-gdbm --tcadb #164

wants to merge 1 commit into from

Conversation

marc-mabe
Copy link
Contributor

This PR enables travis tests of ext/dba with the handlers inifile (buildin), flatfile (buildin), cdb (buildin), gdbm and tcadb.

I also would like to add --with-db4 but can't compile :( - see http://travis-ci.org/#!/marc-mabe/php-src/builds/2138877

@travisbot
Copy link

This pull request fails (merged 99ca7f8 into 018395e).

@reeze
Copy link
Contributor

reeze commented Aug 16, 2012

PHP's test didn't passed in Travis as travisbot reported. currently, it seems useless :(

@nikic
Copy link
Member

nikic commented Aug 16, 2012

It would be nice to get a clean build before adding any more stuff. Right now Travis isn't particularly helpful as it always fails ^^

@marc-mabe
Copy link
Contributor Author

Sure, we need a clean build but it should be clean for all build-in functions. Else we could disable other failed extensions to get a clean build but this doesn't help.

Travis should run all possible test and the bugs/tests should be fixed instead of ignoring tests.

@lstrojny
Copy link
Contributor

@reeze I agree with @nikic here. We need to fix the travis build first (btw: any takers welcome) and than enable more and more extension.

@php-pulls
Copy link

Comment on behalf of lstrojny at php.net:

Closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants