Skip to content

Fix GH-16432: PHP-FPM 8.2 SIGSEGV in fpm_get_status #16564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix GH-16432: PHP-FPM 8.2 SIGSEGV in fpm_get_status #16564

wants to merge 1 commit into from

Conversation

bukka
Copy link
Member

@bukka bukka commented Oct 23, 2024

This fixes GH-16432 which happens when high number of max_children and fpm_get_status is used. The procs need to be allocated on heap in this case.

@bukka bukka mentioned this pull request Oct 23, 2024
Closed
devnexen
devnexen approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO safe* is the proper choice in this case e.g. with its overflow check

@bukka
Copy link
Member Author

bukka commented Nov 23, 2024

Already merged via 065bde1

@bukka bukka closed this Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdos nielsdos nielsdos left review comments

@devnexen devnexen devnexen approved these changes

Assignees
No one assigned
Labels
SAPI: fpm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bukka @devnexen @nielsdos