Use zend_execute_internal always to call internal functions #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow modules that override zend_execute_internal to intercept all internal function calls, not just user-internal calls.
|
Comment on behalf of stas at php.net: merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch restores the use of zend_execute_internal to call internal functions when they are called from another internal function via zend_call_function. This will allow modules to intercept it more efficiently. Unfortunately, this also requires slight API change and may require to fix the overriding function code since new way of calling was added. If the function does anything with execute data, it also would have to consider that some of these data can be wrong for current function if fci parameter is set and take it as overriding authority.