Fixed bug #62976 (Notice: could not be converted to int when comparing s... #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g some builtin classes) If both of the objects can't be casted to compare, they are not equal
|
Comment on behalf of laruence at php.net: I already got a fix last night, just need to test so didin't commit, and seems your fix is not better than mine, so closed. thanks |
|
and btw, your fix is wrong about that -1. according to manual: that means op1 is always greater than op2 if they are both objects |
|
of course I mean they are both objects and can not be compared via normal way |
|
Then I think you could add a test case for that. ensure any future change won't break that :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is a proposal patch for bug #62976 https://bugs.php.net/bug.php?id=62976
It's really surprised to get a true when two different classes's instances was equal,
even they can't be cast.
If both of the objects can't be casted to compare, they are not equal.
for your reference:
http://3v4l.org/f0qlB