ext/intl: Fix for the issue where strlen could potentially become negative #18477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1d13808 to
98d8c09
Compare
98d8c09 to
6ea4225
Compare
youkidearitai
approved these changes
May 1, 2025
devnexen
reviewed
May 1, 2025
| @@ -994,6 +994,10 @@ PHP_FUNCTION(grapheme_levenshtein) | |||
| int32_t strlen_1, strlen_2; | |||
| strlen_1 = grapheme_split_string(ustring1, ustring1_len, NULL, 0); | |||
| strlen_2 = grapheme_split_string(ustring2, ustring2_len, NULL, 0); | |||
| if (UNEXPECTED(strlen_1 < 0 || strlen_2 < 0)) { | |||
There was a problem hiding this comment.
before merging, and since that s the whole point of this PR. can you think of few test cases to trigger this code path ? Cheers.
There was a problem hiding this comment.
Logically, it seems to return -1 when a bad status is received, just like in the following location.
However, I can’t think of a specific way to intentionally reproduce that behavior…
php-src/ext/intl/grapheme/grapheme_string.c
Line 1010 in dd57332
There was a problem hiding this comment.
I tried something simpler, grapheme_strlen except U_MEMORY_ALLOCATION_ERROR I can t think of cases as bad inputs are caught up before that.
devnexen
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grapheme_split_stringreturns-1in case of an error.