GH-18344 add Locale::addLikelySubtags/Locale::minimizeSubtags support. #18487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7def1d9 to
0db5b4d
Compare
nielsdos
approved these changes
May 3, 2025
ext/intl/tests/locale_subtags.phpt
Outdated
| @@ -0,0 +1,35 @@ | |||
| --TEST-- | |||
| Locale::addLikekySubtags/Locale::minimizeSubtags usage | |||
There was a problem hiding this comment.
Suggested change
| Locale::addLikekySubtags/Locale::minimizeSubtags usage | |
| Locale::addLikelySubtags/Locale::minimizeSubtags usage |
…ort. from a minimized locale, addLikelySubtags augments it with likely subtags so no changes is the locale is already maximized e.g. `en_Latn_US`, minimizeSubtags on the other hand does the opposite operation.
0db5b4d to
ebc709a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from a minimized locale, addLikelySubtags augments it with likely subtags so no changes is the locale is already maximized e.g.
en_Latn_US, minimizeSubtags in the other hand does the opposite operation.