Skip to content

Cleanup php_posix_group_to_array() #18497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2025
Merged

Cleanup php_posix_group_to_array() #18497

merged 1 commit into from
May 4, 2025

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented May 4, 2025

This function can be static, and the error checks are pointless:

  1. It's guaranteed that the return value is an array by now, as it is always preceded by array_init(return_value).
  2. The null check for g is pointless as every callee already handles that in a better way.

@nielsdos
Cleanup php_posix_group_to_array()
30a7ab1 
This function can be static, and the error checks are pointless:
1. It's guaranteed that the return value is an array by now,
   as it is always preceded by array_init(return_value).
2. The null check for g is pointless as every callee already
   handles that in a better way.
@nielsdos nielsdos requested a review from devnexen May 4, 2025 17:24
@nielsdos nielsdos merged commit af87ade into php:master May 4, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

Assignees
No one assigned
Labels
Extension: posix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsdos @devnexen