Bug #63000: MCAST_JOIN_GROUP on OSX is broken #185
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The multicast support in PHP 5.4 makes use of MCAST_JOIN_GROUP if it is present. The problem is that OSX 10.7 added the constant, but did not correctly implement the feature. This causes the setsockopt call to fail. The solution to the problem is to not use MCAST_JOIN_GROUP on OSX. For reference, this was also done in VLC: * http://trac.videolan.org/vlc/ticket/6104#comment:19
| #define RFC3678_API 1 | ||
| /* has block/unblock and source membership, in this case for both IPv4 and IPv6 */ | ||
| #define HAS_MCAST_EXT 1 | ||
| #elif defined(IP_ADD_SOURCE_MEMBERSHIP) | ||
| #elif defined(IP_ADD_SOURCE_MEMBERSHIP) && !defined(__APPLE__) | ||
| /* has block/unblock and source membership, but only for IPv4 */ |
There was a problem hiding this comment.
Hi igorw,
did you try 10.8 is that still broken in 10.8?
There was a problem hiding this comment.
Yep, also returns EINVAL in 10.8.
|
Thanks for the fix. Could you add a test verifying it is not enabled on Darwin. Additionally we need to add a warning to the documentation that this feature is not available on Darwin. |
|
Oversaw the test. Merging now. |
|
Comment on behalf of lstrojny at php.net: Merged into 5.4 and master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://bugs.php.net/63000
The multicast support in PHP 5.4 makes use of MCAST_JOIN_GROUP if it is present.
The problem is that OSX 10.7 added the constant, but did not correctly implement
the feature. This causes the setsockopt call to fail.
The solution to the problem is to not use MCAST_JOIN_GROUP on OSX.
For reference, this was also done in VLC: