Skip to content

docs: add macos instruction, update blocks #18670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs: add macos instruction, update blocks #18670

wants to merge 1 commit into from

Conversation

xepozz
Copy link
Contributor

@xepozz xepozz commented May 27, 2025

No description provided.

@xepozz xepozz mentioned this pull request May 27, 2025
Closed
Girgias
Girgias approved these changes May 28, 2025
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit but MSTM

README.md
Or combine the variables:

```shell
make TEST_PHP_ARGS=-j8 TESTS=tests/lang/ test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be consistent across the doc

Suggested change
make TEST_PHP_ARGS=-j8 TESTS=tests/lang/ test
make TEST_PHP_ARGS=-j4 TESTS=tests/lang/ test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xepozz @Girgias