Update filter.c #18740
Open
Update filter.c #18740
+355
−381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor: Optimize performance, memory handling, and error management - Added optimization macros (e.g., `UNEXPECTED`) for rare branches - Used `do_alloca` / `free_alloca` for efficient temporary memory allocation - Replaced verbose conditionals with ternary operators where appropriate - Removed redundant condition checks - Improved variable grouping and naming for readability - Added clearer comments to explain logic - Used `memmove` instead of `memcpy` for overlapping memory regions - Calculated memory sizes more precisely - Introduced helper function `php_stream_bucket_brigade_cleanup` for repeated cleanup logic - Enhanced error handling with additional checks and better resource cleanup - Reduced redundant computations in loops - Improved memory access patterns for better loop performance
|
Hi. Thank you for your contributions. Unfortunately the PR is not in a state where it is meaningfully reviewable, because it combines a large number of unrelated changes into a single commit. Can you please split your changes into individual atomic commits? Please also double-check the CODING_STANDARDS.md, particularly the instructions around indentation. |
This was referenced Jun 2, 2025
devnexen
reviewed
Jun 2, 2025
| /* Compact read buffer if needed */ | ||
| if (stream->readpos > 0) { | ||
| size_t valid_data = stream->writepos - stream->readpos; | ||
| memmove(stream->readbuf, stream->readbuf + stream->readpos, valid_data); |
There was a problem hiding this comment.
this sort of changes ought to be separated from the rest, it is not an improvement but a fix. So hidden by too much pointless changes too.
|
Seeing the shape of changes and the history of other contributions of author I have assumption that this was vibe coded. @itashia, is it true? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor: Optimize performance, memory handling, and error management
UNEXPECTED) for rare branchesdo_alloca/free_allocafor efficient temporary memory allocationmemmoveinstead ofmemcpyfor overlapping memory regionsphp_stream_bucket_brigade_cleanupfor repeated cleanup logic