Remove redundant operations from zend_llist_clean() #19143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function calls zend_llist_destroy() which already sets the head and tail pointers since c732ab4.
Girgias
approved these changes
Jul 15, 2025
| @@ -121,7 +121,6 @@ ZEND_API void zend_llist_destroy(zend_llist *l) | |||
| ZEND_API void zend_llist_clean(zend_llist *l) | |||
There was a problem hiding this comment.
I've had a long-standard todo to just remove this function since it does the same as the _destroy version, and this just makes it clearer - is there a reason not to remove it now?
There was a problem hiding this comment.
More code churn for third party extensions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function calls zend_llist_destroy() which already sets the head and tail pointers since c732ab4.