Skip to content

ext/date: Throw exceptions directly #19166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ext/date: Throw exceptions directly #19166

wants to merge 2 commits into from

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Jul 17, 2025

No description provided.

@Girgias Girgias marked this pull request as ready for review July 17, 2025 23:57
@Girgias Girgias requested a review from derickr as a code owner July 17, 2025 23:57
@Girgias Girgias requested a review from nielsdos August 4, 2025 15:43
derickr
derickr reviewed Aug 8, 2025
View reviewed changes
Copy link
Member

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally OK with this, but I don't like the true/false argument to the functions, and would prefer there to be a define for them — or perhaps reuse EH_NORMAL/EH_THROW?

@Girgias Girgias force-pushed the date-error-handler branch from 17759d6 to df04bee Compare August 8, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derickr derickr derickr left review comments

@nielsdos nielsdos Awaiting requested review from nielsdos

Assignees
No one assigned
Labels
Extension: date
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Girgias @derickr