Remove dead error checks for php_stream_filter_alloc() #19194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
php_stream_filter_alloc() can't fail, so simplify the code.
Girgias
approved these changes
Aug 12, 2025
|
@nielsdos I can see the code is not ready for malloc fail (so it would segfault) but shouldn't we rather add malloc failure check and keep the NULL checks? Or can it not be persistent (I haven't checked that part)? |
That's false, you're looking at the debug code rather than the release code. |
|
Ah yeah it's __zend_malloc for non ZEND_DEBUG. It's a bit strange though that the debug version can fail and potentially segfault. What's the actual reason of not using __zend_malloc in debug build? |
|
Likely an oversight |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php_stream_filter_alloc() can't fail, so simplify the code.