Skip to content

Resolve MSVC C4146 Warning in php_random_uint128.h #19342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

Resolve MSVC C4146 Warning in php_random_uint128.h #19342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ext/random/php_random_uint128.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ static inline uint64_t php_random_pcgoneseq128xslrr64_rotr64(php_random_uint128_
v = (num.hi ^ num.lo),
s = num.hi >> 58U;

return (v >> s) | (v << ((-s) & 63));
return (v >> s) | (v << ((~s + 1) & 63));
}
# else
typedef __uint128_t php_random_uint128_t;
Expand Down Expand Up @@ -121,7 +121,7 @@ static inline uint64_t php_random_pcgoneseq128xslrr64_rotr64(php_random_uint128_
v = ((uint64_t) (num >> 64U)) ^ (uint64_t) num,
s = num >> 122U;

return (v >> s) | (v << ((-s) & 63));
return (v >> s) | (v << ((~s + 1) & 63));
}
# endif

Expand Down