Fix #61557: CGI/FPM process could crash when using libxml #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since d8bddb9 some SAPI would only setup/reset callbacks to libxml once, instead of for each request processed. However, this also included a callback for structured errors, which should remain per request (as it can be defined through PHP's libxml_use_internal_errors). As a result, after the internal handler was set in a request, processing another request would result in the handler being triggered while the memory associated with it (LIBXML(error_list)) had been free-d/reset, leading to the process segfaulting. This reset the handler for structured errors after each request. (Bug #61325 might possibly also be the same bug)
|
As far as I understand the FPM codebase, the patch looks sane. Could you add a testcase for it as well? |
|
I tried to see how tests work, but I'm not sure how to do it. This is a bit of a "special" case I suppose, because in order to test this bug we need to have two different requests processed by the same cgi/fpm process, and I don't know how to make that happen in a test. Otherwise the test can be as simple as running: <?php var_dump(libxml_use_internal_errors(true)); ?>It should always return bool(false), but the second request (on the same process) will return bool(true). Which also means that if the callback was to be used, the process would segfault. |
|
Hm, I see. I guess we are unlucky getting a test here. |
|
Comment on behalf of lstrojny at php.net: Already merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion @ https://bugs.php.net/bug.php?id=61557
Since d8bddb9 some SAPI would only
setup/reset callbacks to libxml once, instead of for each request
processed. However, this also included a callback for structured
errors, which should remain per request (as it can be defined through
PHP's libxml_use_internal_errors).
As a result, after the internal handler was set in a request,
processing another request would result in the handler being triggered
while the memory associated with it (LIBXML(error_list)) had been
free-d/reset, leading to the process segfaulting.
This reset the handler for structured errors after each request.
(Bug #61325 might possibly also be the same bug)