ext/standard: Deprecate passing null to readdir(), rewinddir(), and closedir() #19423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecpl
reviewed
Aug 9, 2025
| @@ -160,6 +160,8 @@ PHP_FUNCTION(dir) | |||
| static php_stream* php_dir_get_directory_stream_from_user_arg(php_stream *dir_stream) | |||
| { | |||
| if (dir_stream == NULL) { | |||
| php_error_docref(NULL, E_DEPRECATED, | |||
| "Passing null is deprecated, instead the last opened directory stream should be provided"); | |||
There was a problem hiding this comment.
I think "the last opened" should be replaced by "a" here.
There was a problem hiding this comment.
The objective of the message is to indicate how to get rid of the deprecation without altering behaviour.
Replacing "the last opened" by "a" is unhelpful here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_passing_null_to_readdir_rewinddir_and_closedir