Skip to content

Zend: Warn when destructuring non-array values #19439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 29, 2025
Merged

Zend: Warn when destructuring non-array values #19439

merged 3 commits into from
Aug 29, 2025

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Aug 9, 2025

@Girgias Girgias force-pushed the 8.5-warn-list-scalar branch from 14aa389 to 037487d Compare August 10, 2025 00:03
@Girgias Girgias force-pushed the 8.5-warn-list-scalar branch 2 times, most recently from 847ad5f to f1bf73d Compare August 26, 2025 12:58
@Girgias
Copy link
Member Author

Girgias commented Aug 26, 2025

@arnaud-lb could you point me towards the correct direction in regards to the CI failure as it seems related to opcache :-/

@arnaud-lb
Copy link
Member

@Girgias the output of ext/opcache/tests/opt/block_pass_003.phpt in https://github.com/php/php-src/actions/runs/17238874731/job/48910311249?pr=19439 looks right (warning printed 20 times). However when enabling JIT the warning is only printed twice because on the second iteration the loop is JIT'ed. You likely need to add a warning in zend_jit_fetch_dim_read().

@Girgias Girgias force-pushed the 8.5-warn-list-scalar branch from f1bf73d to 2bd54ec Compare August 27, 2025 22:46
@Girgias Girgias marked this pull request as ready for review August 28, 2025 08:09
@Girgias Girgias requested a review from dstogov as a code owner August 28, 2025 08:09
@Girgias Girgias requested review from arnaud-lb and a team and removed request for dstogov August 28, 2025 08:09
arnaud-lb
arnaud-lb approved these changes Aug 28, 2025
View reviewed changes
Copy link
Member

@arnaud-lb arnaud-lb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Girgias
Address review comments
cd31ec7 
Merge code blocks, remove relative paths for headers
edorian
edorian approved these changes Aug 29, 2025
View reviewed changes
Copy link
Member

@edorian edorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RM approval 👍

@Girgias Girgias merged commit 8747e9a into php:master Aug 29, 2025
9 checks passed
@Girgias Girgias deleted the 8.5-warn-list-scalar branch August 29, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edorian edorian edorian approved these changes

@arnaud-lb arnaud-lb arnaud-lb approved these changes

Assignees
No one assigned
Labels
Category: Engine Extension: opcache RFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Girgias @arnaud-lb @edorian @DanielEScherzer