[RFC] Deprecate imagedestroy() #19454
Merged
+44
−103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To avoid merge conflicts, NEWS/UPGRADING will be sent once this is approved |
TimWolla
reviewed
Aug 12, 2025
| @@ -629,6 +629,7 @@ function imagegd2(GdImage $image, ?string $file = null, int $chunk_size = 128, i | |||
| /** @param resource|string|null $file */ | |||
| function imagebmp(GdImage $image, $file = null, bool $compressed = true): bool {} | |||
|
|
|||
| #[\Deprecated(since: '8.5', message: "as it has no effect since PHP 8.0")] | |||
There was a problem hiding this comment.
Didn't notice in the RFC, but the consistent wording with the existing functions would be:
Suggested change
| #[\Deprecated(since: '8.5', message: "as it has no effect since PHP 8.0")] | |
| #[\Deprecated(since: '8.5', message: "as GdImage objects are freed automatically")] |
There was a problem hiding this comment.
since we proposed the wording on the RFC, I'd prefer to start with using that message and then we can tweak it in a separate patch if desired; same for the other patches for the no-op deprecations
There was a problem hiding this comment.
Okay with me (that's why I opted just to comment rather than “Request Changes”).
| @@ -13,7 +13,7 @@ imagecolortransparent($im, $trans_color); | |||
| imagefilledrectangle($im, 0,0, 192,36, $trans_color); | |||
| $c = imagecolorat($im, 191,35); | |||
| imagegif($im, $dest); | |||
| imagedestroy($im); | |||
| $im = null; | |||
There was a problem hiding this comment.
Suggested change
| $im = null; | |
| unset($im); |
I have a feeling that unset() would capture the intent a little better, but no strong opinion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_imagedestroy