[Fix] parse_url: don’t treat colon in path as port #19527 #19528
+46
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @arshidkv12. Did you follow the discussion in GH-7890? We can't adjust the parsing for invalid URLs due to backwards compatibility concerns. See https://wiki.php.net/rfc/url_parsing_api for the new URL parsing API that will be available in 8.5. |
|
@iluuu1994 Sorry, I hadn’t checked that. Thanks for pointing it out! I’ll review the new URL parsing API in PHP 8.5. |
|
No worries, thanks for getting back to me. And let us know if you find any issues with the new API. |
|
Thanks! I’ll keep an eye out and let you know if anything comes up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
parse_url()to avoid treating a colon followed by digits inside the path as a port number.Before:
After