Fix #27814. Construct HTTP request headers into smart_str #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 28, 2016 19:17
|
Replaced by PR 2053 which is against 5.6.25. |
|
Sorry for the delay, I have now merged this into PHP 7.1+ as 318d3b3. I've landed it in 7.1 only because it's a feature request rather than bug fix. Thanks! |
|
Small followup to replace use of scratch with direct writes to the smart_str: #2054 Would appreciate a quick review. |
|
Given https://bugs.php.net/bug.php?id=53615 this sounds somewhat bug-ish, so might want to apply it to 7.0 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All request headers will be sent at the same time.