Support building using the native client toolchain. #205
Conversation
The native client compiler defines the C macro __x86_64__, but the size of an unsigned int is only 4 bytes. This causes the compile to fail because the inline asm code compiled is for an 8 byte unsigned int. Add the correct defines to fix this. As detailed in: http://code.google.com/p/nativeclient/issues/detail?id=2255
* PHP-5.4: Support building PHP with the native client toolchain.
* 5.4-nacl: Support building PHP with the NaCl toolchain.
Use the correct basic_machine for nacl.
More wrapping of inline __asm__ with defined(__native_client__)
These inline asm statements are incompatible with native client, and give errors when running ncval, which cause the binary to fail loading.
|
@sjlangley I feel incompetent to do anything useful with this PR (and btw sorry for the long time without any response). I guess the best way forward would be, if you write a mail to internals explaining what your plans are with NaCl and ask for karma to maintain NaCl support. |
|
Thanks - will look into it. On Sun, Jan 6, 2013 at 12:38 PM, Lars Strojny notifications@github.comwrote:
|
|
Really, please do. I would love to see NaCl support in PHP. |
Conflicts: Zend/zend_operators.h config.sub
|
This patch deletes Zend/zend_operators.h. Not something that should be done. Please squash and re-do it correctly. |
|
Comment on behalf of krakjoe at php.net: This PR is in very poor condition. If this is still a problem that needs solving, anyone watching is free to open a clean PR. Closing ... |
Add build rules for cross compiling using a native client compiler.
Add correct defines around inline asm so that the correct code is built for native client.