Update list of common Mime Types in PHP development server #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Web audio/video formats (Webm ,and Ogg containers) + have jpeg mime types listed together
|
Looks good, but we need a test for it :) |
|
No idea how tests are done in PHP :) Do you have a pointer to documentation or an existing similar test for mime types I could use as an example? |
|
I have updated an existing test that was already testing the mime types, the test had a lot of duplicated code so I factorized it.. |
|
What is the next step? |
|
I'll test and merge it. Please give me a few more days. |
|
Thanks |
|
Comment on behalf of lstrojny at php.net: Merged into 5.4, 5.5 and master. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update list of common Mime Types in PHP development server to support HTML5 Web audio/video formats (Webm ,and Ogg containers) + have all jpeg mime types listed together.
Should I make separate pull requests to have that in a 5.4.x release or a pull request to master is enough?