Updated openSSL to fix timout issue on SSL streams - Bug #61285 #264
Conversation
Read and write on blocking SSL based IO will now obey the configured timeout.
|
Looks like the git clone on the build request above timed out... You may want to re-try, with higher timeout values on GIT. |
Updated to meet existing style, and PHP coding standards.
|
There seems to be quite a lot of duplicate logic. Do you think you can refactor this? See also |
|
When I get the opportunity, I will look into it. I really don't have Thanks On 2013-02-03 10:26, Gustavo Lopes wrote:
Links:[1] |
Per requests from users, I refactored the read / write methods and pulled out some of the common code between the new refactored method and php_openssl_enable_crypto(). Personally, I think that too much factoring can reduce readability, but it was specifically asked for.
|
Now that the aforementioned refactoring is done... Could anyone merge this already please? |
|
@bbroerman30 BTW, you have finished said refactoring, right? |
|
A long time ago. From: Vasil Rangelov [mailto:notifications@github.com] @bbroerman30 https://github.com/bbroerman30 BTW, you have finished said Reply to this email directly or view it on |
Conflicts: ext/openssl/xp_ssl.c
This should fix bugs 61285 and 62605. I have tested with blocking and non-blocking SSL streams in PHP and in a PHP extension I am working on.