Skip to content

PDO mysql meta type (fix bug #48724) #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

PDO mysql meta type (fix bug #48724) #271

wants to merge 3 commits into from

Conversation

danielbeardsley
Copy link
Contributor

PDO's getColumnMeta() wasn't returning native_type for BIT, TINYINT and YEAR.

Manually tested, and updated the tests that have always been disabled.

smalyshev and others added 3 commits February 29, 2012 07:25
@smalyshev
5.4.0
76b580d
@tony2001 @marczych
fix bug #48724
43a652d 
PDO's getColumnMeta() doesn't return native_type for BIT, TINYINT and YEAR
@danielbeardsley
Tests: PDO Mysql - update for fixed getColumnMeta()
5ff4d7b 
The test has always been disabled... so it's never run anyway. Oh well.
@smalyshev
Copy link
Contributor

This patch needs a test.

@danielbeardsley
Copy link
Contributor Author

The existing tests have been modified to account for this change, though they have been and still remain disabled.

@smalyshev
Copy link
Contributor

The test fails for me with this:

Testing native PS...
[620 + 6] Expecting native type array (
  0 => 'ENUM',
), array (
  'native_type' => 'STRING',
  'pdo_type' => 2,
  'flags' =>
  array (
  ),
  'table' => 'test',
  'name' => 'label',
  'len' => 3,
  'precision' => 0,
)
[630 + 6] Expecting native type array (
  0 => 'SET',
), array (
  'native_type' => 'STRING',
  'pdo_type' => 2,
  'flags' =>
  array (
  ),
  'table' => 'test',
  'name' => 'label',
  'len' => 6,
  'precision' => 0,
)
done!

@smalyshev
Copy link
Contributor

If I remove the ENUM/SET test changes, test passes just fine. So I think I'll merge without this change, @danielbeardsley - please see what is happening there.

@php-pulls
Copy link

Comment on behalf of stas at php.net:

merged

@php-pulls php-pulls closed this Jun 17, 2013
@dunglas dunglas mentioned this pull request Sep 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielbeardsley @smalyshev @php-pulls @tony2001