ext/curl interface.c: modify curl_setopt_handler to allow resetting CURLOPT_HEADERFUNCTION callback #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…URLOPT_HEADERFUNCTION callback Sometimes it may be useful to remove a CURLOPT_HEADERFUNCTION callback (this is supported in the cURL API by passing NULL as callback), e.g. when doing cURL FTP with custom commands like MLST which need a CURLOPT_HEADERFUNCTION to parse the server return, and then wanting to do other FTP commands which would be irritated by the presence of a CURLOPT_HEADERFUNCTION callback. This absolutely needs more work, especially checking if the CURLOPT_HEADERFUNCTION handler was something other (like a stream redirect) - the current implementation just checks if the previous handler was a user callback and errors out otherwise.
…FUNCTION) is called when the handler is PHP_CURL_IGNORE already
…lly break if the previous handler was not a function
|
some tests maybe here too? |
|
@msmuenchen ping? |
|
@msmuenchen so what about tests? |
|
Comment on behalf of krakjoe at php.net: Since the work on this patch was never completed, and since it has merge conflicts with master today, and since it had no tests for QA, I'm closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it may be useful to remove a CURLOPT_HEADERFUNCTION callback (this
is supported in the cURL API by passing NULL as callback), e.g. when doing
cURL FTP with custom commands like MLST which need a CURLOPT_HEADERFUNCTION
to parse the server return, and then wanting to do other FTP commands which
would be irritated by the presence of a CURLOPT_HEADERFUNCTION callback.
This absolutely needs more work, especially checking if the
CURLOPT_HEADERFUNCTION handler was something other (like a stream redirect) -
the current implementation just checks if the previous handler was a user
callback and errors out otherwise.