Fixed bug #64248 #282
Closed
Fixed bug #64248 #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+1 |
|
this definitely need a RFC |
|
For more information on what an RFC is, refer to https://wiki.php.net/rfc |
|
Otherwise I'll like it but the patch needs tests and making it return a boolean return value is a good idea as well. |
|
I've requested a php-wiki account for creating a rfc. I'll now change the unset language construct and rebase it to PHP-5.5 as you don't consider it as a bug fix only. |
|
Why is this closed? This would be very useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This little patch enables unset() to behave as a normal expr. This has for result that unset now returns a random int. While a good alternative for the (mt_)rand() functions, an idea would be to make unset return true if the variable has existed else false?