Fixed bug #64235 (Insteadof not work for class method in 5.4.11) #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
actually, I was looking into this, I have thought the similar fix of you, but |
|
Comment on behalf of laruence at php.net: wrong fix, this fix need more works than it look like. |
|
What intend output in your code? http://3v4l.org/UpMCW after the fix, 5.4's behavior is consist |
|
yes, it's consistent, but do you think it's right? do you think it's acceptable ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the traits refactor, it "fixed" the traits precedence which could use class but not trait that was not intend from the design and manual.
this PR fixes the BC, and the same time deprecate the behavior.
This is a 5.4 only patch.