Update run_001.phpt #2913
Closed
Update run_001.phpt #2913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update test to avoid that it freezes the test suite
cmb69
reviewed
Nov 14, 2017
sapi/phpdbg/tests/run_001.phpt
Outdated
| @@ -52,5 +52,7 @@ prompt> | |||
| 1 2 3 | |||
| --FILE-- | |||
| <?php | |||
|
|
|||
| if is_null($argc) || is_null($argv) { | |||
KalleZ
suggested changes
Nov 14, 2017
sapi/phpdbg/tests/run_001.phpt
Outdated
| @@ -52,5 +52,7 @@ prompt> | |||
| 1 2 3 | |||
| --FILE-- | |||
| <?php | |||
|
|
|||
| if is_null($argc) || is_null($argv) { | |||
Sorry for my fault! I corrected the code. In addition, the change in the phptt try resolve the error mentioned here: https://bugs.php.net/bug.php?id=75499
|
It would be better to find out why that code freezes phpdbg ... /cc @bwoebi |
|
Hello, where do we see that the code freezes here? I think it passes successfully. Is it something with gcov, travis somewhere or where is this happening? Thanks... |
|
I had tested again and the test passed. =====================================================================
|
|
Great. Thank you @royopa too. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update test to avoid that it freezes the test suite