-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Fixed Bug #61025 __invoke() visibility not honored #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| --TEST-- | ||
| Bug #61025 (__invoke() visibility not honored) invoke private | ||
| --FILE-- | ||
| <?php | ||
|
|
||
| class FooPrivate { | ||
| private function __invoke() { | ||
| echo __CLASS__ . "::" . __FUNCTION__ . "()\n"; | ||
| } | ||
| } | ||
| $foo_private = new FooPrivate(); | ||
|
|
||
| $foo_private(); | ||
| ?> | ||
| ===DONE=== | ||
| --EXPECTF-- | ||
| Fatal error: Call to private FooPrivate::__invoke() from context '' in %s/bug61025-1.php on line %d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| --TEST-- | ||
| Bug #61025 (__invoke() visibility not honored) is_callable consist | ||
| --FILE-- | ||
| <?php | ||
|
|
||
| class FooPublic { | ||
| public function __construct() { | ||
| echo "Check in class: " . __CLASS__ . " \$this is callable: "; | ||
| echo is_callable($this) ? 'true' : 'false'; | ||
| echo "\n"; | ||
| } | ||
| public function __invoke() { | ||
| echo __CLASS__ . "::" . __FUNCTION__ . "()\n"; | ||
| } | ||
| } | ||
|
|
||
| class FooProtected { | ||
| public function __construct() { | ||
| echo "Check in class: " . __CLASS__ . " \$this is callable: "; | ||
| echo is_callable($this) ? 'true' : 'false'; | ||
| echo "\n"; | ||
| } | ||
|
|
||
| protected function __invoke() { | ||
| echo __CLASS__ . "::" . __FUNCTION__ . "()\n"; | ||
| } | ||
| } | ||
|
|
||
| class FooPrivate { | ||
| public function __construct() { | ||
| echo "Check in class: " . __CLASS__ . " \$this is callable: "; | ||
| echo is_callable($this) ? 'true' : 'false'; | ||
| echo "\n"; | ||
| } | ||
|
|
||
| private function __invoke() { | ||
| echo __CLASS__ . "::" . __FUNCTION__ . "()\n"; | ||
| } | ||
| } | ||
|
|
||
| $foo_public = new FooPublic(); | ||
| echo "Check outter is callable: "; | ||
| echo is_callable($foo_public) ? 'true' : 'false'; | ||
| echo "\n\n"; | ||
|
|
||
| $foo_protected = new FooProtected(); | ||
| echo "Check outter is callable: "; | ||
| echo is_callable($foo_protected) ? 'true' : 'false'; | ||
| echo "\n\n"; | ||
|
|
||
| $foo_private = new FooPrivate(); | ||
| echo "Check outter is callable: "; | ||
| echo is_callable($foo_private) ? 'true' : 'false'; | ||
| echo "\n\n"; | ||
| ?> | ||
| ===DONE=== | ||
| --EXPECT-- | ||
| Check in class: FooPublic $this is callable: true | ||
| Check outter is callable: true | ||
|
|
||
| Check in class: FooProtected $this is callable: true | ||
| Check outter is callable: false | ||
|
|
||
| Check in class: FooPrivate $this is callable: true | ||
| Check outter is callable: false | ||
|
|
||
| ===DONE=== |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| --TEST-- | ||
| Bug #61025 (__invoke() visibility not honored) raise warning when using static | ||
| --FILE-- | ||
| <?php | ||
|
|
||
| interface IInvoke { | ||
| public static function __invoke(); | ||
| } | ||
|
|
||
| class Foo { | ||
| public static function __invoke() { | ||
| echo __CLASS__; | ||
| } | ||
| } | ||
| ?> | ||
| ===DONE=== | ||
| --EXPECTF-- | ||
| Warning: The magic method __invoke() cannot be static in %s/bug61025-3.php on line %d | ||
|
|
||
| Warning: The magic method __invoke() cannot be static in %s/bug61025-3.php on line %d | ||
| ===DONE=== |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| --TEST-- | ||
| Bug #61025 (__invoke() visibility not honored) | ||
| --FILE-- | ||
| <?php | ||
|
|
||
| class FooPublic { | ||
| public function __invoke() { | ||
| echo __CLASS__ . "::" . __FUNCTION__ . "()\n"; | ||
| } | ||
| } | ||
|
|
||
| class FooProtected { | ||
| protected function __invoke() { | ||
| echo __CLASS__ . "::" . __FUNCTION__ . "()\n"; | ||
| } | ||
| } | ||
|
|
||
| $closure = function () { | ||
| echo "Closure\n"; | ||
| }; | ||
|
|
||
| $foo_public = new FooPublic(); | ||
| $foo_protected = new FooProtected(); | ||
|
|
||
| $closure(); | ||
| $foo_public(); | ||
| $foo_protected(); | ||
| ?> | ||
| ===DONE=== | ||
| --EXPECTF-- | ||
| Closure | ||
| FooPublic::__invoke() | ||
|
|
||
| Fatal error: Call to protected FooProtected::__invoke() from context '' in %s/bug61025.php on line %d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don’t we miss a return 0 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I only see four conditions, they are closure function and other three possible ZEND_ACC_PPP* flags.
or else it's common function, but that wouldn't happen when get the function with get_closure